Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 73 73
Lines 8791 8791
=======================================
Hits 6747 6747
Misses 2044 2044 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hugobuddel
left a comment
hugobuddel
left a comment
There was a problem hiding this comment.
It is good to be able to build the docs locally. E.g. wouldn't that have helped with debugging #689 ?
And we were planning to build the documentation (including notebooks, and inline-code) on zeus and then uploading to RTD, so we don't have to store the notebooks with output. So maybe keep the makefile?
I think that only really applies to the IRDB for now, because building the ScopeSim docs themselves doesn't require too many resources, so building (incl. all notebooks) entirely on RTD is fine.
Yeah, I guess it wouldn't hurt to keep that ability. I'm re-drafting this for now and come back once I understand how local Sphinx builds actually work (never done that, always relied on RTD). |
2 participants
RTD build just fine without them. Nobody builds the docs locally anyway AFAIK. So this is just deadweight.